program: safe deserialize instruction #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Nov 7, 2024
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
This makes sense to me! Just a few little bits for maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Similar to solana-program/config#16, the Address Lookup Table program imposes a limit on the provided instruction buffer length. However, the
ExtendLookupTableinstruction uses a vector of pubkeys, resulting in a vector length stored in the first 8 bytes of the buffer after the discriminator.If that vector length is very large, even if the rest of the buffer is invalid, the allocator in the BPF version will attempt to allocate a large vector and exhaust the heap.
Summary of Changes
Add a
safe_deserialize_instructionhelper to check the vector length before attempting deserialization.